From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5E31C71C7C for ; Fri, 10 Jun 2022 11:20:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 554672569B for ; Fri, 10 Jun 2022 11:20:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DEEBF25690 for ; Fri, 10 Jun 2022 11:20:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B252443AAF for ; Fri, 10 Jun 2022 11:20:25 +0200 (CEST) Message-ID: Date: Fri, 10 Jun 2022 11:20:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: pve-devel@lists.proxmox.com, Matthias Heiserer References: <20220527114810.510501-1-m.heiserer@proxmox.com> <20220527114810.510501-3-m.heiserer@proxmox.com> From: Fabian Ebner In-Reply-To: <20220527114810.510501-3-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.921 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.732 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v4 manager] HDEdit: check iothread by default and move it from advanced section X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2022 09:20:56 -0000 Am 27.05.22 um 13:48 schrieb Matthias Heiserer: > Existing disks are not changed by this. > Especially in benchmarks, iothreads significantly improve IO performance. > > Signed-off-by: Matthias Heiserer Reviewed-by: Fabian Ebner > --- > > Changes from v3: > * remove automatically switching to/from SCSI single when iothread is (un)checked > * iothread will be initially set on > * changing the controller to something other than SCSI single and then back to > SCSI single will enable iothread for all SCSI disks. I like this version much more. We could still add validation/warning to the checkbox, but IMHO not a big deal with the new default and improved warning upon VM start. Just wondering if we should enable iothread by default for virtio disks too, or is the performance improvement not as relevant there?