From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6819291DAE for ; Sat, 11 Mar 2023 18:34:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4DAE42B9F9 for ; Sat, 11 Mar 2023 18:34:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 11 Mar 2023 18:34:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7CDBD42732 for ; Sat, 11 Mar 2023 18:34:10 +0100 (CET) Message-ID: Date: Sat, 11 Mar 2023 18:34:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Thunderbird/111.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion , Dominik Csapak References: <20230306142335.3858041-1-d.csapak@proxmox.com> <20230306142335.3858041-5-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230306142335.3858041-5-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 4/7] ui: VMSelector: correctly change invalid class on en/disable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2023 17:34:11 -0000 Am 06/03/2023 um 15:23 schrieb Dominik Csapak: > since we manually handle the invalid class, we have to manually trigger > that on setDisabled > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/VMSelector.js | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js > index fb54e4835..399c4e658 100644 > --- a/www/manager6/form/VMSelector.js > +++ b/www/manager6/form/VMSelector.js > @@ -140,6 +140,8 @@ Ext.define('PVE.form.VMSelector', { > } else { > sm.deselectAll(); > } > + // to correctly trigger invalid class > + me.getErrors(); > }, > > setValue: function(value) { > @@ -163,7 +165,7 @@ Ext.define('PVE.form.VMSelector', { > > getErrors: function(value) { > let me = this; > - if (me.allowBlank === false && > + if (!me.isDisabled() && me.allowBlank === false && while at it you could have changed the odd `allowBlank === false` to just `!allowBlank` ;-)