From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5C64A1FF38C for ; Fri, 31 May 2024 14:56:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CBF54355AC; Fri, 31 May 2024 14:56:53 +0200 (CEST) Message-ID: Date: Fri, 31 May 2024 14:56:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Dominik Csapak References: <20240419124556.3334691-1-d.csapak@proxmox.com> <20240419124556.3334691-9-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240419124556.3334691-9-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qemuserver.pm] Subject: Re: [pve-devel] [PATCH qemu-server v3 04/10] stop cleanup: remove unnecessary tpmstate cleanup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Adding the rationale for third-party plugins from last time: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062354.html Am 19.04.24 um 14:45 schrieb Dominik Csapak: > tpmstate0 is already included in `get_vm_volumes`, and our only storage > plugin that has unmap_volume implemented is the RBDPlugin, where we call > unmap in `deactivate_volume`. So it's already ummapped by the > `deactivate_volumes` calls above. > For third-party storage plugins, it's natural to expect that deactivate_volume() would also remove a mapping for the volume just like RBDPlugin does. While there is an explicit map_volume() call in start_swtpm(), a third-party plugin might expect an explicit unmap_volume() call too. However, the order of calls right now is 1. activate_volume() 2. map_volume() 3. deactivate_volume() 4. unmap_volume() Which seems like it could cause problems already for third-party plugins relying on an explicit unmap call. All that said, it is unlikely that a third-party plugin breaks. If it really happens, it can be discussed/adapted to the actual needs still. > Signed-off-by: Dominik Csapak Acked-by: Fiona Ebner > --- > PVE/QemuServer.pm | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 28e630d3..680c36f2 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -6172,14 +6172,6 @@ sub vm_stop_cleanup { > if (!$keepActive) { > my $vollist = get_vm_volumes($conf); > PVE::Storage::deactivate_volumes($storecfg, $vollist); > - > - if (my $tpmdrive = $conf->{tpmstate0}) { > - my $tpm = parse_drive("tpmstate0", $tpmdrive); > - my ($storeid, $volname) = PVE::Storage::parse_volume_id($tpm->{file}, 1); > - if ($storeid) { > - PVE::Storage::unmap_volume($storecfg, $tpm->{file}); > - } > - } > } > > foreach my $ext (qw(mon qmp pid vnc qga)) { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel