From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6F8861FF16B for ; Fri, 10 Oct 2025 09:30:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E234BE091; Fri, 10 Oct 2025 09:30:42 +0200 (CEST) Message-ID: Date: Fri, 10 Oct 2025 09:30:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: pve-devel@lists.proxmox.com References: <20251010072802.798062-1-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20251010072802.798062-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760081406353 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] fix #6815: ui: resource tree: update tag colors properly X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" forgot to write, this should be backported to stable-8 too, should be cleanly cherry-pickable On 10/10/25 9:28 AM, Dominik Csapak wrote: > In commit: > e19de81f (ui: resource tree: fix change detection) > the change detection for resource tree nodes was fixed so that it did > not update on every refresh anymore. > > This now also means that when the ui options are loaded (which contains > the tag color overrides) we now have to correctly update nodes which > contains tags, otherwise the standard colors will be shown. > > There is already an event handler for the 'loadedUiOptions', so simply > adapt it to also update the tree nodes that contains tags. > > Fixes: e19de81f (ui: resource tree: fix change detection) > Signed-off-by: Dominik Csapak > --- > www/manager6/tree/ResourceTree.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js > index 315976e0..e83ccfc8 100644 > --- a/www/manager6/tree/ResourceTree.js > +++ b/www/manager6/tree/ResourceTree.js > @@ -605,7 +605,7 @@ Ext.define('PVE.tree.ResourceTree', { > me.mon(Ext.GlobalEvents, 'loadedUiOptions', () => { > me.store.getRootNode().cascadeBy({ > before: function (node) { > - if (node.data.groupbyid) { > + if (node.data.groupbyid || node.data.tags) { > node.beginEdit(); > let info = node.data; > me.setIconCls(info); _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel