From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 18227BAFDB for ; Fri, 22 Mar 2024 14:38:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 003916947 for ; Fri, 22 Mar 2024 14:37:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 22 Mar 2024 14:37:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 04FB441A1B for ; Fri, 22 Mar 2024 14:37:48 +0100 (CET) Message-ID: Date: Fri, 22 Mar 2024 14:37:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20240318111836.1947580-1-d.csapak@proxmox.com> <20240318111836.1947580-7-d.csapak@proxmox.com> From: Fiona Ebner In-Reply-To: <20240318111836.1947580-7-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 4/4] api: enable live migration for marked mapped pci devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2024 13:38:22 -0000 Am 18.03.24 um 12:18 schrieb Dominik Csapak: > They have to be marked as 'live-migration-capable' in the mapping > config, and the driver and qemu must support it. > > For the gui checks, we now return a list of 'mapped-with-live-migration' > entries in the migration preflight api call too. > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Qemu.pm | 5 +++++ > PVE/QemuMigrate.pm | 12 ++++++++---- > 2 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 4ecaeb91..8581a529 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -4453,6 +4453,10 @@ __PACKAGE__->register_method({ > type => 'array', > description => "List of mapped resources e.g. pci, usb" > }, > + 'mapped-with-live-migration' => { > + type => 'array', > + description => "List of mapped resources that are marked as capable of live-migration", > + }, Should we merge this with 'mapped-resources' for the next major release (and add a reminder comment here)? I.e. make that return the objects with the additional information. > }, > }, > code => sub {