From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3705A78610 for ; Fri, 30 Apr 2021 08:39:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1C15B24750 for ; Fri, 30 Apr 2021 08:38:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A11F224742 for ; Fri, 30 Apr 2021 08:38:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7572946277 for ; Fri, 30 Apr 2021 08:38:36 +0200 (CEST) To: pve-devel@lists.proxmox.com References: <20210204102606.17447-1-f.ebner@proxmox.com> From: Fabian Ebner Message-ID: Date: Fri, 30 Apr 2021 08:38:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210204102606.17447-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [glusterfsplugin.pm, plugin.pm] Subject: Re: [pve-devel] [PATCH storage] clone image: specify base format option with qemu-img X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2021 06:39:07 -0000 Ping Am 04.02.21 um 11:26 schrieb Fabian Ebner: > and avoid a warning. It is deprecated to auto-detect the format of the base > volume. See commit d9f059aa6cfccefaffa3532556e966df4a99ece2 in qemu for more > information. > > Signed-off-by: Fabian Ebner > --- > PVE/Storage/GlusterfsPlugin.pm | 2 +- > PVE/Storage/Plugin.pm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/PVE/Storage/GlusterfsPlugin.pm b/PVE/Storage/GlusterfsPlugin.pm > index 2dd414d..5ec2f42 100644 > --- a/PVE/Storage/GlusterfsPlugin.pm > +++ b/PVE/Storage/GlusterfsPlugin.pm > @@ -228,7 +228,7 @@ sub clone_image { > my $volumepath = "gluster://$server/$glustervolume/images/$vmid/$name"; > > my $cmd = ['/usr/bin/qemu-img', 'create', '-b', "../$basevmid/$basename", > - '-f', 'qcow2', $volumepath]; > + '-F', $format, '-f', 'qcow2', $volumepath]; > > run_command($cmd, errmsg => "unable to create image"); > > diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm > index d2d8184..bd8b345 100644 > --- a/PVE/Storage/Plugin.pm > +++ b/PVE/Storage/Plugin.pm > @@ -708,7 +708,7 @@ sub clone_image { > local $CWD = $imagedir; > > my $cmd = ['/usr/bin/qemu-img', 'create', '-b', "../$basevmid/$basename", > - '-f', 'qcow2', $path]; > + '-F', $format, '-f', 'qcow2', $path]; > > run_command($cmd); > }; >