From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EC25962CC8 for ; Fri, 18 Sep 2020 12:07:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DCA7914FC4 for ; Fri, 18 Sep 2020 12:07:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BE7A114FB5 for ; Fri, 18 Sep 2020 12:07:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8427745432 for ; Fri, 18 Sep 2020 12:07:04 +0200 (CEST) To: Proxmox VE development discussion , Stoiko Ivanov References: <20200917191701.2236-1-s.ivanov@proxmox.com> <20200917191701.2236-3-s.ivanov@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Fri, 18 Sep 2020 12:07:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Thunderbird/81.0 MIME-Version: 1.0 In-Reply-To: <20200917191701.2236-3-s.ivanov@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.193 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: Re: [pve-devel] [PATCH container 1/1] sync_container_namespace: skip virtual filesystems X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 10:07:36 -0000 On 9/17/20 9:17 PM, Stoiko Ivanov wrote: > skip additional virtual filesystems. > > the list is taken from a running debian container's /proc/mounts > > Signed-off-by: Stoiko Ivanov > --- > src/PVE/LXC.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index b3e3581..b67d872 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -1107,7 +1107,7 @@ my $do_syncfs = sub { > my $mounts = PVE::ProcFSTools::parse_mounts($mountdata); > foreach my $mp (@$mounts) { > my ($what, $dir, $fs) = @$mp; > - next if $fs eq 'fuse.lxcfs'; > + next if $fs =~ /cgroup|devtmpfs|devpts|fuse.lxcfs|mqueue|fusectl|proc|sysfs|tmpfs/; the comparison isn't exact any more, maybe add ^ and $ anchors, or use a hash. We could also use the presence of "nodev" in `cat /proc/filesystems`, albeit zfs may need to be parsed separate, all others are either ram backed (sync not useful) or really virtually computed once. Just as an idea... > eval { PVE::Tools::sync_mountpoint($dir); }; > warn $@ if $@; > } >