From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AC3B51FF161 for ; Tue, 22 Oct 2024 13:23:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BD560B88B; Tue, 22 Oct 2024 13:23:56 +0200 (CEST) Message-ID: Date: Tue, 22 Oct 2024 13:23:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Maximiliano Sandoval References: <20241001140833.330843-1-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20241001140833.330843-1-m.sandoval@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm] Subject: Re: [pve-devel] [PATCH qemu] api: qemu: create: default cpu to x86-64-v2-AES X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 01.10.24 um 16:08 schrieb Maximiliano Sandoval: > This makes it so newly created VMs, e.g. with `qm create` will have the > same default value as VMs created via the web UI. > > Signed-off-by: Maximiliano Sandoval > --- > I am not entirely sure if there is side-effect that I am not taking into account. > This is a breaking change, because existing API callers now suddenly get a new default. Even if it were just CLI and not API, it would be breaking for the same reason (there are scripts using the CLI tools out there). If we do this, then in a major release and prominently communicate it to all users in the release notes. And it should also be documented it in the API schema, that creation uses another default than the schema default. > PVE/API2/Qemu.pm | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index d25a79fe..383218fd 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -1152,6 +1152,10 @@ __PACKAGE__->register_method({ > $conf->{vmgenid} = PVE::QemuServer::generate_uuid(); > } > > + if (!defined($param->{cpu})) { > + $conf->{cpu} = 'x86-64-v2-AES'; > + } > + > my $machine_conf = PVE::QemuServer::Machine::parse_machine($conf->{machine}); > my $machine = $machine_conf->{type}; > if (!$machine || $machine =~ m/^(?:pc|q35|virt)$/) { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel