From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C1E9B632FC for ; Thu, 24 Feb 2022 13:38:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B9E4D7CD2 for ; Thu, 24 Feb 2022 13:38:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 359687CC7 for ; Thu, 24 Feb 2022 13:38:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0938541CD4 for ; Thu, 24 Feb 2022 13:38:21 +0100 (CET) Message-ID: Date: Thu, 24 Feb 2022 13:38:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Thunderbird/98.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20220222153350.1808592-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220222153350.1808592-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH novnc] parse error 'already started' on guest start X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 12:38:21 -0000 On 22.02.22 16:33, Dominik Csapak wrote: > when we start an already started container, we get an error instead > of a task that fails > > so to have similar behaviour between vm and ct, we parse that error > for the start command and behave like it was successful > > put it in the first patch and rebase the rest of them > > Signed-off-by: Dominik Csapak > --- > .../0001-add-PVE-specific-JS-code.patch | 19 ++++++++++++++----- > .../0012-pass-custom-command-to-vnc.patch | 2 +- > ...passing-deprecated-upgrade-parameter.patch | 2 +- > ...-create-own-class-for-hidden-buttons.patch | 6 +++--- > ...-button-on-isFullscreen-get-variable.patch | 4 ++-- > ...ow-start-button-on-not-running-vm-ct.patch | 8 ++++---- > 6 files changed, 25 insertions(+), 16 deletions(-) > > applied, with the commit subject/message fixed up, thanks!