From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 4B8941FF164
for <inbox@lore.proxmox.com>; Fri, 14 Mar 2025 10:33:39 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id E8DB93754D;
Fri, 14 Mar 2025 10:33:27 +0100 (CET)
Message-ID: <aa092130-7d45-44e3-9936-ff621cd656c9@proxmox.com>
Date: Fri, 14 Mar 2025 10:33:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: pve-devel@lists.proxmox.com
References: <20250313124956.367059-1-g.goller@proxmox.com>
<285a3e7b-30e9-4162-9b2d-cbdb0d8d5810@proxmox.com>
<zjcd5mtjczr4fltdi6tal5lbr6jtnsf2b4f35e734ik2s42nxf@kgaphbcyxizo>
Content-Language: en-GB
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <zjcd5mtjczr4fltdi6tal5lbr6jtnsf2b4f35e734ik2s42nxf@kgaphbcyxizo>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.039 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH frr] frr: fix bit flag collision in patch
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 13/03/2025 16:49, Gabriel Goller wrote:
> On 13.03.2025 16:16, Thomas Lamprecht wrote:
>> w.r.t. versioning I'd have bumped the pve1 part to pve2.
>
> So '10.2.1-1+pve2'?
Exactly.
>>> + * fix fabricd dummy_as_loopback flag collision
>>
>> collision with what? these entries should be telling for end users (not devs).
>
> True, a simpler "fix fabricd dummy_as_loopback flag" would be enough.
No, my question was with what this collides, your correction does not answer
that at all and is equally "bad" compared to the original. Maybe something
along the lines of:
* fix collision in fabricd for the option values of the recent dummy-as-loopback
backport and a internal test mode, where enabling one would always enable the
other.
As that tells admins actually what collided and what the basic effect was.
>>> +
>>> + -- Gabriel Goller <g.goller@proxmox.com> Thu, 13 Mar 2025 13:33:46 +0100
I overlooked that above should be 'Proxmox Support Team <support@proxmox.com>'
dch uses the DEBEMAIL environment variable here, so you can add something like
export DEBEMAIL='Proxmox Support Team <support@proxmox.com>'
to your shell's rc file to get that correct, makes most sense if you primarily
develop on Proxmox projects on that host, e.g. I have a dedicated development VM
to contain all this stuff, otherwise adding an alias that sets this correctly
might be also an option.
> Stefan said the exact same thing :)
> This is done quite commonly in frr e.g.:
> https://git.proxmox.com/?p=mirror_frr.git;a=blob;f=bgpd/bgpd.h;h=9cb1d51088cfc456f344b17b8068f84d382e3751;hb=HEAD#l210.
> But I don't think it's that bad anyway :).
If they use it already, then fine, but lets not introduce this in any of our
(C) code.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel