From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B114960961 for ; Sat, 6 Feb 2021 15:11:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9AAA211E21 for ; Sat, 6 Feb 2021 15:10:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2CD9D11E14 for ; Sat, 6 Feb 2021 15:10:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E85E941B01 for ; Sat, 6 Feb 2021 15:10:36 +0100 (CET) Message-ID: Date: Sat, 6 Feb 2021 15:10:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20201117113836.16895-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20201117113836.16895-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [RFC/PATCH qemu] fix #3084: fall back to open-iscsi initiatorname X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Feb 2021 14:11:07 -0000 On 17.11.20 12:38, Fabian Ebner wrote: > Fixes vma restore when the target is an iSCSI storage which expects that > initiatorname. Also avoids the need to always explicitly set the initiatorname > in PVE code, thus fixing moving efidisks from and to such iSCSI storages. > > Signed-off-by: Fabian Ebner > --- > > The obvious alternative is to add the option in vma itself. But I'd like to > hear some opinions about this approach first. One downside is that the old > default behavior (i.e. using iqn.2008-11.org.linux-kvmXXX) is overwritten as > long as an initiatorname can be read from /etc/iscsi/initiatorname.iscsi, but > as PVE only reads the initiatorname from there, relying on that behavior seems > to be incompatible with our tooling anyways. > > ...all-back-to-open-iscsi-initiatorname.patch | 71 +++++++++++++++++++ > debian/patches/series | 1 + > 2 files changed, 72 insertions(+) > create mode 100644 debian/patches/pve/0057-PVE-fall-back-to-open-iscsi-initiatorname.patch > > applied, thanks! Had to resolve a trivial merge-conflict as there was a 0057 patch applied in between, so this is now 0058.