From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8D775711D3 for ; Wed, 8 Sep 2021 13:02:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8B650251BE for ; Wed, 8 Sep 2021 13:02:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 28B8A251B0 for ; Wed, 8 Sep 2021 13:02:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F188B4351E for ; Wed, 8 Sep 2021 13:02:05 +0200 (CEST) Message-ID: Date: Wed, 8 Sep 2021 13:01:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Thunderbird/92.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210906113231.61790-1-f.ebner@proxmox.com> <20210906113231.61790-4-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210906113231.61790-4-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.304 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager 3/6] ui: prune edit: prepare for being re-used for backup jobs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 11:02:06 -0000 On 06.09.21 13:32, Fabian Ebner wrote: > 1. Rename the isPBS variable to match the actual purpose. When editing > a backup job, the hint should not be shown, even if the storage is > PBS. > > 2. Allow specifying the text used for the fallback hint. For backup > jobs, the first fallback is the storage configuration, so the text > needs to be different there. > > 3. Make using keep-all=1 by default upon creation optional. For backup > jobs, the default should be "use fallback", i.e. no settings. > > Signed-off-by: Fabian Ebner > --- > www/manager6/panel/EditPruneInputPanel.js | 10 ++++++---- > www/manager6/storage/Base.js | 4 +++- > 2 files changed, 9 insertions(+), 5 deletions(-) > > applied, thanks!