From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 734E46024C for ; Mon, 16 Nov 2020 18:26:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 63ECB9571 for ; Mon, 16 Nov 2020 18:26:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id F0D3A9567 for ; Mon, 16 Nov 2020 18:26:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B676D417D0 for ; Mon, 16 Nov 2020 18:26:13 +0100 (CET) To: Proxmox VE development discussion , =?UTF-8?Q?Dominic_J=c3=a4ger?= References: <20201028100454.313122-1-d.jaeger@proxmox.com> <20201028100454.313122-3-d.jaeger@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Mon, 16 Nov 2020 18:26:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201028100454.313122-3-d.jaeger@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -1.238 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record TVD_SUBJ_WIPE_DEBT 2.291 Spam advertising a way to eliminate debt URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lvmthinplugin.pm] Subject: [pve-devel] applied: [PATCH pve-storage 3/3 v2] lvmthin: Match snapshot remove regex to allowed names X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2020 17:26:44 -0000 On 28.10.20 11:04, Dominic J=C3=A4ger wrote: > We allow snapshot names that match pve-configid but during qm destroy w= e have > not removed all snapshots that match pve-configid so far. For example, = the name > x-y was allowed but the resulting snap_vm-105-disk-0_x-y was not remove= d. >=20 > Reported-by: Hannes Laimer > Signed-off-by: Dominic J=C3=A4ger > --- > Requires the pve-common patches >=20 > v1->v2: Use the now public regex instead of the verify function >=20 > The "use constant" variant requires a backslash > ${\PVE::JSONSchema::CONFIGID_RE} for each usage and the getter/method v= ariant > requires postponed regular subexpressions m/^(??{get_configid_re()})$/)= , so > "our" looked the most simple to me. >=20 > PVE/Storage/LvmThinPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > applied, thanks!