From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F16B1609BD for ; Thu, 13 Jan 2022 13:03:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E79221DA3A for ; Thu, 13 Jan 2022 13:03:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 812D21DA2A for ; Thu, 13 Jan 2022 13:03:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4ED6A46AE0 for ; Thu, 13 Jan 2022 13:03:46 +0100 (CET) Message-ID: Date: Thu, 13 Jan 2022 13:03:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20220113075633.473258-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220113075633.473258-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager] add 'auto' mode for noVNC scaling X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jan 2022 12:03:47 -0000 On 13.01.22 08:56, Dominik Csapak wrote: > in commit > 69c6561f820b4fdb5625ead767889155db9f1539 ("ui: fix novnc scaling radio button") > > we always set to 'scale' when no value was set, but a non-set value > actually had a different behaviour: > > in the embedded console it was set to 'scale', but in the pop-up it was > set to 'off'. > > to restore this behaviour, introduce an option 'auto' which unsets the > 'novnc-scaling' setting > > Signed-off-by: Dominik Csapak > --- > www/manager6/window/Settings.js | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > applied, thanks!