From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1C2D01FF19B for ; Fri, 21 Feb 2025 11:13:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 464D92CEE4; Fri, 21 Feb 2025 10:50:16 +0100 (CET) Message-ID: Date: Fri, 21 Feb 2025 10:50:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Daniel Kral References: <20250211160825.254167-1-d.kral@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250211160825.254167-1-d.kral@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH container/qemu-server/storage v2 00/31] consistent assertions for volume's content types X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 11.02.25 um 17:07 schrieb Daniel Kral: > == Possible squash == > > I was unsure how granular the patches here should be, so I left it at > the finest granularity to make reviewing easier, but there's room for > squashing patches together: > > - qemu-server #10-#14, > - pve-container #3-#5, and > - pve-container #7-#11. Personally, I'm totally fine with having them separate in such a case. The modifications touch different parts of the code and have no real interdependency, so it will only be easier to track back a problematic change when bisecting should the need really arise. Also makes it easier to keep track of what is affected by each change when looking over changelog/history. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel