From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id 17ED162E76 for ; Tue, 24 Nov 2020 14:53:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id 7C3B2DCD8 for ; Tue, 24 Nov 2020 14:53:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id F0DF8DCCB for ; Tue, 24 Nov 2020 14:53:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id B6F0C404F5; Tue, 24 Nov 2020 14:53:18 +0100 (CET) To: Proxmox VE development discussion , Alwin Antreich References: <20201124105811.1416723-1-a.antreich@proxmox.com> From: Dominik Csapak Message-ID: Date: Tue, 24 Nov 2020 14:53:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: <20201124105811.1416723-1-a.antreich@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.320 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [tools.pm, pools.pm, ceph.pm, pveceph.pm] Subject: Re: [pve-devel] [PATCH manager v2 0/8] ceph: allow pools settings to be changed X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2020 13:53:20 -0000 high level comment it seems the series depends on pg autoscaling to be enabled, but on my nautilus installation it was not so i'd say we have to handle that by not querying autoscaling settings if it is disabled or wrapping the mon call in an eval, else the whole pool view does not work (i get an 500) On 11/24/20 11:58 AM, Alwin Antreich wrote: > This set allows to edit pools via GUI & CLI. This should make it easier > for users to adjust pool settings, since they don't have to go the ceph > tool route. > > v1 -> v2: > - move pools endpoint to a subclass > - add pg autsocale status and settings > - rework and flatten the grid view of ceph pools > - rework the create input panel > - add an edit button using the reworked input panel > - fix borken add_storages > - extend setp_pool function to avoid a race condition > - remove the pg_autoscale_mode default to allow Ceph's setting to > take precedence > > > Alwin Antreich (8): > api: ceph: subclass pools > ceph: add get api call for single pool > ceph: add autoscale_status to api calls > ceph: gui: add autoscale & flatten pool view > ceph: gui: rework pool input panel > ceph: schema: change min. required PG count to 1 > ceph: remove the pg_autoscale_mode default > fix: ceph: always set pool size first > > PVE/API2/Ceph/Makefile | 1 + > PVE/API2/Ceph.pm | 380 +------------------------ > PVE/API2/Ceph/POOLS.pm | 572 ++++++++++++++++++++++++++++++++++++++ > PVE/CLI/pveceph.pm | 12 +- > PVE/Ceph/Tools.pm | 70 ++++- > www/manager6/ceph/Pool.js | 405 +++++++++++++++++++-------- > 6 files changed, 950 insertions(+), 490 deletions(-) > create mode 100644 PVE/API2/Ceph/POOLS.pm >