From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AC8D71FF2AD for ; Wed, 3 Jul 2024 11:03:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C0C9A44E4; Wed, 3 Jul 2024 11:03:58 +0200 (CEST) Message-ID: Date: Wed, 3 Jul 2024 11:03:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: pve-devel@lists.proxmox.com, =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= References: <20240614110042.56739-1-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20240614110042.56739-1-f.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH v2 qemu] fix #4726: avoid superfluous check in vma code X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 14.06.24 um 13:00 schrieb Fiona Ebner: > The 'status' pointer is dereferenced regardless of the NULL check, > i.e. 'status->closed' is accessed after the branch with the check. > Since all callers pass in the address of a struct on the stack, the > pointer can never be NULL. Remove the superfluous check and add an > assert instead. > > Signed-off-by: Fiona Ebner applied with Fabian's R-b given for v1, because it's the very same change, but v2 has a slightly improved commit message. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel