From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9D8501FF15C for <inbox@lore.proxmox.com>; Wed, 19 Mar 2025 10:21:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF2A15847; Wed, 19 Mar 2025 10:21:46 +0100 (CET) Message-ID: <a77d5505-f2dd-4238-87f8-316629364b99@proxmox.com> Date: Wed, 19 Mar 2025 10:21:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: lou.lecrivain@orange.fr, pve-devel@lists.proxmox.com References: <20250306110831.6426-1-lou.lecrivain@orange.fr> Content-Language: en-US From: =?UTF-8?Q?Hannes_D=C3=BCrr?= <h.duerr@proxmox.com> In-Reply-To: <20250306110831.6426-1-lou.lecrivain@orange.fr> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH-SERIES pve-network v3] Add Nautobot IPAM support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: jonatan.crystall@gwdg.de Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> In general the plugin implementation seems sensible, the only thing I didn't quite understand is the need for `get_status_ip`, more on that inline. The series no longer applies to master, as there have been patches that add a fingerprint parameter to the API request [0]. For testing purposes I have already adapted the code and wanted to ask if it is okay for you if I continue the patchseries as co-author with my adjustments? Of course you both remain registered as author. [0] https://git.proxmox.com/?p=pve-network.git;a=commit;h=894d2d33e3b104bcdc8b83e3f205427db93800c3 On 3/6/25 12:08, lou.lecrivain@orange.fr wrote: > From: Lou Lecrivain <lou.lecrivain@wdz.de> > > Following review from Hannes, > > I have made some improvements to the form of the code for the pve-network part. > No functional changes. > > Related changes to pve-manager and pve-docs are also included the email thread. > > BR > > Lou Lecrivain (3): > ipam: nautobot: base plugin > ipam: nautobot: add testing for nautobot plugin > ipam: nautobot: add checks for prefix deletion > > src/PVE/API2/Network/SDN/Ipams.pm | 1 + > src/PVE/Network/SDN/Ipams.pm | 3 + > src/PVE/Network/SDN/Ipams/Makefile | 2 +- > src/PVE/Network/SDN/Ipams/NautobotPlugin.pm | 491 ++++++++++++++++++ > src/test/ipams/nautobot/expected.add_ip | 11 + > .../ipams/nautobot/expected.add_ip_notgateway | 11 + > .../ipams/nautobot/expected.add_next_freeip | 11 + > src/test/ipams/nautobot/expected.add_subnet | 11 + > src/test/ipams/nautobot/expected.del_ip | 11 + > src/test/ipams/nautobot/expected.update_ip | 11 + > src/test/ipams/nautobot/ipam_config | 24 + > src/test/ipams/nautobot/sdn_config | 20 + > src/test/ipams/netbox/ipam_config | 8 +- > src/test/ipams/phpipam/ipam_config | 8 +- > 14 files changed, 620 insertions(+), 3 deletions(-) > create mode 100644 src/PVE/Network/SDN/Ipams/NautobotPlugin.pm > create mode 100644 src/test/ipams/nautobot/expected.add_ip > create mode 100644 src/test/ipams/nautobot/expected.add_ip_notgateway > create mode 100644 src/test/ipams/nautobot/expected.add_next_freeip > create mode 100644 src/test/ipams/nautobot/expected.add_subnet > create mode 100644 src/test/ipams/nautobot/expected.del_ip > create mode 100644 src/test/ipams/nautobot/expected.update_ip > create mode 100644 src/test/ipams/nautobot/ipam_config > create mode 100644 src/test/ipams/nautobot/sdn_config > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel