From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5D44C1FF09C for ; Mon, 05 Oct 2026 16:36:34 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E341321628; Mon, 05 Oct 2026 16:36:31 +0200 (CEST) Message-ID: Date: Mon, 5 Oct 2026 16:36:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/16] Support for custom EFI firmware To: Christian Ludwig , pve-devel@lists.proxmox.com References: Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791210983048 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.481 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6GHE7WGJ6P65AITRXGQXND7JVPO2K7P5 X-Message-ID-Hash: 6GHE7WGJ6P65AITRXGQXND7JVPO2K7P5 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Christian, Am 28.09.26 um 7:48 AM schrieb Christian Ludwig: > Hi, > > here is an updated patch series that brings support for custom UEFI > firmware images. You can find the v1 series at [1] for reference. > > In Confidential Computing the aim is to not trust the hypervisor, yet it > runs its bundled firmware in each VM. Some VM appliances also ship their > own firmware images. This series allows to bring your own firmware for > OVMF based VMs. > > Today the Proxmox-VE API allows to import a custom efidisk0 (EFIVAR) > already. EFI firmware and EFIVAR data have to match. Otherwise, the VM > might not boot anymore. Therefore, with this series you can set a custom > EFI firmware via the API, along with a custom efidisk. But these are two > steps. And there is no safety net. The GUI is missing a way to set a > custom EFIVAR. So this series only allows to set a custom firmware image > for confidential computing VMs that do not need EFIVAR storage. The > defaults do not change. > Looks mostly good to me (haven't looked at UI/docs yet). Apart from comments on the individual patches, I do have two design questions/considerations: Format Extensions ================= Would it be an issue to require/restrict file extensions here, i.e. only allow names ending with '.fd', '.raw' and '.img' or similar? 1. It would protect against potential confusion, e.g. otherwise, there can be a filename ending in '.qcow2'. While the code will look at the returned format which is hard-coded/enforced to be 'raw', such a name would still be confusing. 2. It would also allow us to extend support to non-raw formats in the future. For example, we probably want to support IGVM [0] files as well at some point. Have you already looked at that this format and what do you think about it regarding your use case? [0]: https://www.qemu.org/docs/master/system/igvm.html 'bios' as property string ========================= I wonder if we should turn 'bios' into a property string with the firmware file as a sub-property? This would couple the properties more tightly. === Happy to hear opinions about these from you and also other developers! Best Regards, Fiona