From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 39A101FF17C for <inbox@lore.proxmox.com>; Wed, 25 Jun 2025 09:58:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE08BFA43; Wed, 25 Jun 2025 09:59:11 +0200 (CEST) Message-ID: <a740a724-6a2c-48ed-b632-f674c19c4831@proxmox.com> Date: Wed, 25 Jun 2025 09:59:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Wolfgang Bumiller <w.bumiller@proxmox.com> References: <20250611144903.200940-1-f.schauer@proxmox.com> <20250611144903.200940-3-f.schauer@proxmox.com> <kach4fhw746f3ndkjr5li44kqanwooxclvltdrauhiito6f2v5@cabliu7hj5qd> Content-Language: en-US From: Filip Schauer <f.schauer@proxmox.com> In-Reply-To: <kach4fhw746f3ndkjr5li44kqanwooxclvltdrauhiito6f2v5@cabliu7hj5qd> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-perl-rs v2 02/11] add Perl mapping for OCI container image parser/extractor X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: pve-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 24/06/2025 14:51, Wolfgang Bumiller wrote: >> + #[export] >> + pub fn parse_and_extract_image( >> + oci_tar_path: &str, >> + rootfs_path: &str, >> + ) -> Result<Option<Config>, Error> { >> + match proxmox_oci::parse_and_extract_image(oci_tar_path, rootfs_path) { >> + Ok(config) => Ok(Some(config.unwrap_or_default())), >> + Err(err) => match err { >> + ProxmoxOciError::ParseError(ParseError::NotAnOciImage(_)) => Ok(None), > ^ Why are we doing this? In the Perl code of the create_vm API method at PVE::API2::LXC, if a .tar file is used as the container template, PVE::RS::OCI::parse_and_extract_image is first attempted. It returns undef, when the .tar file is not an OCI image. Thus we deduce that the file is an LXC template. If some other kind of error occurrs, (e.g. I/O error) then the Perl code should die. The point is, there needs to be a way to differentiate between the file actually being an LXC template, and some general failure. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel