From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.whyte@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id CA31175A16
 for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 12:30:37 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id B40EB1A8C1
 for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 12:30:07 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 2C5321A8B4
 for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 12:30:07 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EE3EB4618E
 for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 12:30:06 +0200 (CEST)
To: Stefan Reiter <s.reiter@proxmox.com>, pve-devel@lists.proxmox.com
References: <20210422082507.22747-1-s.reiter@proxmox.com>
From: Dylan Whyte <d.whyte@proxmox.com>
Message-ID: <a71f1d28-194c-c858-53eb-1171880b83f0@proxmox.com>
Date: Thu, 22 Apr 2021 12:30:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210422082507.22747-1-s.reiter@proxmox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.001 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH docs 1/2] vzdump: add section about
 live-restore
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2021 10:30:37 -0000

Hi,

I just made some very minor suggestions inline, but overall it's good (i 
had to search extra-hard for issues) :)

Reviewed-by: Dylan Whyte <d.whyte@proxmox.com>

On 4/22/21 10:25 AM, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> As discussed off-list, the vzdump section in general seems a bit misorganized,
> and is certainly missing some references to PBS. Dylan agreed to take a look at
> it, thanks again for that!
>
>   vzdump.adoc | 28 ++++++++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
>
> diff --git a/vzdump.adoc b/vzdump.adoc
> index 9453684..0577a97 100644
> --- a/vzdump.adoc
> +++ b/vzdump.adoc
> @@ -337,6 +337,34 @@ per configured storage, this can be done with:
>   # pvesm set STORAGEID --bwlimit restore=KIBs
>   ----
>   
> +Live-Restore
> +~~~~~~~~~~~~
> +
> +Restoring a large backup can take a long time, in which a guest is still
> +unavailable. For VM backups stored on a Proxmox Backup Server, this wait
> +time can be mitigated using the live-restore option.
> +
> +Enabling live-restore via either the checkbox in the GUI or the `--live-restore`
> +property for `qmrestore` causes the VM to start immediately as the restore

s/property for/argument of/

s/immediately/as soon/

> +begins. Data is copied in the background, chunks that the VM is actively

s/, chunks/, and chunks/

or to reformulate: "Data is copied in the background, prioritizing 
chunks that the VM is actively accessing."

> +accessing are prioritized.
> +
> +Note that this comes with two caveats:
> +
> +* During live-restore, the VM will operate with limited disk read speeds, as
> +  data has to be loaded from the backup server (once loaded it is immediately
s/once loaded/once loaded,/
> +  available on the destination storage however, so accessing data twice only
> +  incurs the penalty the first time). Write speeds are largely unaffected.
> +* If the live-restore fails for any reason, the VM will be left in an
> +  unspecified state - that is, not all data might have been copied from the
s/unspecified/undefined/
> +  backup, and it is _most likely_ not possible to keep any data that was written
> +  during the failed restore operation.
> +
> +This mode of operation is especially useful for large VMs, where only a small
> +amount of data is required for initial operation, e.g. web servers - once the OS
> +and necessary services are started, the VM is already operational, while the

s/are started/have been started/

s/already operational/operational/

> +background task keeps copying seldomly used data.

s/keeps/continues/

> +
>   [[vzdump_configuration]]
>   Configuration
>   -------------