From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 141728CAFC for ; Fri, 4 Nov 2022 14:17:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CD5F734F7 for ; Fri, 4 Nov 2022 14:17:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 4 Nov 2022 14:17:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3C1DA44CC9 for ; Fri, 4 Nov 2022 14:17:31 +0100 (CET) Message-ID: Date: Fri, 4 Nov 2022 14:17:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak References: <20221104105644.1808000-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221104105644.1808000-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH http-server] upload: allow whitespaces in filenames X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2022 13:17:33 -0000 Am 04/11/2022 um 11:56 schrieb Dominik Csapak: > some fields (e.g. filename) can contain spaces, but our 'trim' function, > would only return the value until the first whitespace character instead > of removing leading/trailing white space. this lead to giving the wrong > filename to the api call (e.g. 'foo' instead of 'foo (1).iso') which > would reject it because of the 'wrong' extension > > this patch fixes that by using a more robust regex replacement > > fixes commit: > 0fbcbc2 ("fix #3990: multipart upload: rework to fix uploading small files") > > Signed-off-by: Dominik Csapak > --- > while looking at the code, i noticed there is now the unused function > 'parse_content_disposition', so i'd suggest we either use that instead, > or remove it if we don't need it we could also just use the existing PVE::Tools::trim() that does what we want already? w.r.t. parse_content_disposition: I'm not really sure if that's the best fit for the altered "architecture" any more, iow. rather no easy one line +- change. Maybe it's better to drop it, I found no other usage in our packages.