From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 14E3D81B9 for ; Thu, 2 Mar 2023 14:15:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EAFED3F37 for ; Thu, 2 Mar 2023 14:15:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 2 Mar 2023 14:15:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8C92648CEB; Thu, 2 Mar 2023 14:15:11 +0100 (CET) Message-ID: Date: Thu, 2 Mar 2023 14:15:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20230222093655.2645787-1-a.lauterer@proxmox.com> <20230222093655.2645787-2-a.lauterer@proxmox.com> From: Dominik Csapak In-Reply-To: <20230222093655.2645787-2-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.106 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.09 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 1/2] ui: ceph: make the warning detail button stand out more X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2023 13:15:43 -0000 one nit inline: On 2/22/23 10:36, Aaron Lauterer wrote: > The button for more details is barely noticable as something one can > click on. By making it more obvious that it is a button, users will > hopefully notice it easier. > > Signed-off-by: Aaron Lauterer > --- > > While moving code around I also changed: > - var -> let > - string concat to template literals > > www/manager6/ceph/Status.js | 56 +++++++++++++++++++------------------ > 1 file changed, 29 insertions(+), 27 deletions(-) > > diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js > index bdcf3f1b..45583f51 100644 > --- a/www/manager6/ceph/Status.js > +++ b/www/manager6/ceph/Status.js > @@ -101,37 +101,39 @@ Ext.define('PVE.node.CephStatus', { > flex: 1, > }, > { > - xtype: 'actioncolumn', > + xtype: 'widgetcolumn', > width: 40, > align: 'center', > tooltip: gettext('Detail'), > - items: [ > - { > - iconCls: 'x-fa fa-info-circle', > - handler: function(grid, rowindex, colindex, item, e, record) { > - var win = Ext.create('Ext.window.Window', { > - title: gettext('Detail'), > - resizable: true, > - modal: true, > - width: 650, > - height: 400, > - layout: { > - type: 'fit', > - }, > - items: [{ > - scrollable: true, > - padding: 10, > - xtype: 'box', > - html: [ > - '' + Ext.htmlEncode(record.data.summary) + '', > - '
' + Ext.htmlEncode(record.data.detail) + '
', > - ], > - }], > - }); > - win.show(); > - }, > + widget: { > + xtype: 'button', > + baseCls: 'x-btn', > + userCls: 'x-btn-default-toolbar-small', > + iconCls: 'fa fa-fw fa-info-circle x-btn-icon-el-default-toolbar-small', > + handler: function() { > + let record = this.getWidgetRecord(); > + let win = Ext.create('Ext.window.Window', { > + title: gettext('Detail'), > + resizable: true, > + modal: true, > + width: 650, > + height: 400, > + layout: { > + type: 'fit', > + }, > + items: [{ > + scrollable: true, > + padding: 10, > + xtype: 'box', > + html: [ > + `${Ext.htmlEncode(record.data.summary)}`, > + `
${Ext.htmlEncode(record.data.detail)}
`, > + ], > + }], > + }); > + win.show(); when touching this, you could add 'autoShow: true' to the properties, then we don't have to save the window in a variable at all (and don't call .show()) not a reason to send a v2 though > }, > - ], > + }, > }, > ], > },