From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C87FF692E6 for ; Thu, 12 Nov 2020 17:07:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C4E8212D30 for ; Thu, 12 Nov 2020 17:07:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0AE7712D22 for ; Thu, 12 Nov 2020 17:07:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D21DF421D5 for ; Thu, 12 Nov 2020 17:07:17 +0100 (CET) To: Proxmox VE development discussion , Stefan Reiter References: <20201112154400.28457-1-s.reiter@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Thu, 12 Nov 2020 17:07:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201112154400.28457-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.096 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] applied: [PATCH 0/2] Fix systemd ordering for qmeventd.service X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2020 16:07:18 -0000 On 12.11.20 16:43, Stefan Reiter wrote: > Reported in the forum: > https://forum.proxmox.com/threads/shutdown-reboot-error-nodes.78906/ > > Since qmeventd is now responsible for stopping QEMU instances after they shut > down, it needs to keep running for as long as there are guests, otherwise the > host will hang waiting for guests to exit. > > Fix this in pve-guests.service for regular VMs and pve-ha-lrm.service for HA. > > I'm not too familiar with systemd services, but I figured the After is enough, > since Wants implies that qmeventd must be running for the services to work, > which is not true, the VMs will work fine, as long as the user takes care of > cleanup themselves somehow or doesn't use shutdown (and by default > qmeventd.service is enabled anyway). But easy enough to change if that's wrong. > > Not sure how to handle version bumping, I'd assume qemu-server needs a depends > on new pve-manager and pve-ha-manager to ensure non-broken behaviour? > > > manager: Stefan Reiter (1): > stop qmeventd.service after pve-guests.service > > services/pve-guests.service | 1 + > 1 file changed, 1 insertion(+) > > ha-manager: Stefan Reiter (1): > stop qmeventd.service after pve-ha-lrm.service > > debian/pve-ha-lrm.service | 1 + > 1 file changed, 1 insertion(+) > applied the reverse to qemu-server, thanks!