From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 483297B13C for ; Fri, 29 Oct 2021 11:33:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 35392B668 for ; Fri, 29 Oct 2021 11:32:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8EEB9B659 for ; Fri, 29 Oct 2021 11:32:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6079F4694C for ; Fri, 29 Oct 2021 11:32:29 +0200 (CEST) To: pve-devel@lists.proxmox.com References: <20210913120446.23392-1-f.ebner@proxmox.com> From: Fabian Ebner Message-ID: Date: Fri, 29 Oct 2021 11:32:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210913120446.23392-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.700 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.905 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nodes.pm] Subject: Re: [pve-devel] [PATCH-SERIES manager/proxmox-ve] warn against/prevent using virtual console for major upgrade X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2021 09:33:00 -0000 Could I get some feedback for this? Am 13.09.21 um 14:04 schrieb Fabian Ebner: > Quoting from the upgrade notes: > >> Perform the actions via console or ssh; preferably via console to avoid >> interrupted ssh connections. Do not carry out the upgrade when connected >> via the virtual console offered by the GUI; as this will get interrupted >> during the upgrade. > > But some users still seem to miss this, so let's be more direct. > > One part is proxmox-ve patches #1 and #2, just mentioning it up front. > > The other two patches (sent as RFC, as I'm not sure this is the best > approach), would make it a hard error when a console started via > API/GUI is detected upon attempting a major upgrade. > > > All patches are also intended for stable-6. Note that proxmox-ve does > not currently have a stable-6 branch, I used > 286285a9a441ad5b1a3c1869373bfbaadbb70bb4 as a base when testing. > > > proxmox-ve depends on pve-manager for the new behavior to take effect, > but it's not a hard dependency. > > > pve-manager: > > Fabian Ebner (1): > api: nodes: set environment variable for shells started via the API > > PVE/API2/Nodes.pm | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > > proxmox-ve: > > Fabian Ebner (3): > apt hook: avoid long line and fix typo > apt hook: mention that console/ssh should be used for major upgrade > apt hook: disallow major upgrade via virtual console from API/UI > > debian/apthook/pve-apt-hook | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) >