From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6B44D6A863 for ; Wed, 16 Mar 2022 18:48:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CC2D2AC19 for ; Wed, 16 Mar 2022 18:48:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A04EF2AC0E for ; Wed, 16 Mar 2022 18:48:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3200046DBD; Wed, 16 Mar 2022 18:48:11 +0100 (CET) Message-ID: Date: Wed, 16 Mar 2022 18:48:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , Alexandre Derumier References: <20220306124647.2267293-1-aderumier@odiso.com> <20220306124647.2267293-2-aderumier@odiso.com> From: Thomas Lamprecht In-Reply-To: <20220306124647.2267293-2-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH V2 qemu-server 1/2] enable balloon free-page-reporting X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 17:48:13 -0000 On 06.03.22 13:46, Alexandre Derumier wrote: > Allow balloon device driver to report hints of guest free pages to the host, > for auto memory reclaim > > https://lwn.net/Articles/759413/ > https://events19.linuxfoundation.org/wp-content/uploads/2017/12/KVMForum2018.pdf > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 42f0fbd..a9e86b3 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -3846,7 +3846,9 @@ sub config_to_command { > # enable balloon by default, unless explicitly disabled > if (!defined($conf->{balloon}) || $conf->{balloon}) { > my $pciaddr = print_pci_addr("balloon0", $bridges, $arch, $machine_type); > - push @$devices, '-device', "virtio-balloon-pci,id=balloon0$pciaddr"; > + my $ballooncmd = "virtio-balloon-pci,id=balloon0$pciaddr"; > + $ballooncmd .= ",free-page-reporting=on" if min_version($machine_version, 6, 2); do we even need to guard this behind 6.2 machine version, as I tried to add it on a running host and migrations in both directions went just fine with a windows 10 VM. Asking mostly because we already have QEMU 6.2 available publicly on pvetest and use it also for some infrastructure of ours, so if it really would be breaking we'd need to use our separate qemu-version independent machine bump mechanism (+pve1). But it seems that its not required, or did you find that it can indeed break live migration? fwiw, for us is really only forward migration, from vm without reporting enabled to vm with reporting enabled, relevant. > + push @$devices, '-device', $ballooncmd; > } > > if ($conf->{watchdog}) {