From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 61623956D9 for ; Wed, 18 Jan 2023 14:53:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4028420B61 for ; Wed, 18 Jan 2023 14:53:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 18 Jan 2023 14:53:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 58F7844336 for ; Wed, 18 Jan 2023 14:53:08 +0100 (CET) Message-ID: Date: Wed, 18 Jan 2023 14:53:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Content-Language: en-GB To: Proxmox VE development discussion , Christoph Heiss References: <20230118130135.631553-1-c.heiss@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230118130135.631553-1-c.heiss@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.097 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: storage backup view: Update remove button on protection change X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2023 13:53:40 -0000 Looks ok (but did not tested it yet), few small nits inline Am 18/01/2023 um 14:01 schrieb Christoph Heiss: > Currently this works in the backup view for containers/VMs, but not in > the storage backup view. Implement that for the latter part too. > > Uses the callback functionality of the load() method of the store to > properly update the UI as soon as loading is finished. > While at it, clean up the same thing in grid/BackupView.js to remove the replace file name with (parts of) the module name or xtype. > current hack. > > Signed-off-by: Christoph Heiss > --- > FWIW, using me.store.load({..}) directly in grid/BackupView.js works > perfectly fine too (as I would expect). But I reused reload() for now, > to keep consistency with the rest of the file. Thus the added `args`. > > www/manager6/grid/BackupView.js | 16 +++++++--------- > www/manager6/storage/BackupView.js | 6 +++++- > 2 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js > index 7f7e1b62..dda8a363 100644 > --- a/www/manager6/grid/BackupView.js > +++ b/www/manager6/grid/BackupView.js > @@ -79,9 +79,9 @@ Ext.define('PVE.grid.BackupView', { > ]); > }; > > - var reload = Ext.Function.createBuffered(function() { > + var reload = Ext.Function.createBuffered(function(args) { two nits: - please transform to `let` or `const` when touching anyway - s/args/options/ to be more in line with ExtJS terminology [0] for this parameter as otherwise it somewhat suggests one could pass arbitrary `arguments`. [0]: https://docs.sencha.com/extjs/7.0.0/classic/Ext.data.Store.html#method-load > if (me.store) { > - me.store.load(); > + me.store.load(args); > } > }, 100); >