From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E56CD1FF16F for ; Fri, 15 Nov 2024 17:59:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 098401A20B; Fri, 15 Nov 2024 17:59:16 +0100 (CET) Message-ID: Date: Fri, 15 Nov 2024 17:58:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Aaron Lauterer To: pve-devel@lists.proxmox.com References: <20241112092554.106723-1-a.lauterer@proxmox.com> In-Reply-To: <20241112092554.106723-1-a.lauterer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.035 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH widget-toolkit v6 0/4] fix #3893: make bridge vids configurable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" sent a v7 https://lore.proxmox.com/pve-devel/20241115165753.2664489-1-a.lauterer@proxmox.com/T/#t On 2024-11-12 10:25, Aaron Lauterer wrote: > Dropped patch 1/7 that introduced PVE::Tools::list_is_empty. We check > direclty in the two call sites. > Patches 2 & 3 from the previous series have been applied in the > meantime. > > this version reworks a few parts since > v5: > * drop PVE::Tools::list_is_empty completely and run the empty check > directly in the two call sites > * Change UI label and description text > * Put UI description text into a gettext > > v4: incorporated @fionas suggestions, besides some style nits: > * rename check_list_empty to list_is_empty and adapt the return values > * renamed $check_vid to $valid_vid with return values for each case > * switch list separators to spaces in the API call, instead of when > writing the file > * rework small logical error in the check if the end VLAN ID is larger > than the start and $noerr is set. > > v3: incorporated @shannons recommendations, in detail: > * improve regex with non-capturing group > * reworked check if valid VLAN config in UI field check > * small code style and spelling things > * reworded UI explanation text for bridge vids > > v2: > * renamed format in JSONSchema to a more generic `pve-vlan-id-or-range` > * explicitly use spaces when writing interfaces file. This is one > possible approach to deal with the fact, that the generic `-list` > format will accept quite a few delimiters and we need spaces. > * code style improvements such as naming the regex results. > * add parameter verification to the web ui > > widget-toolkit: Aaron Lauterer (2): > fix #3892: Network: add bridge vids field for bridge_vids > Network: add explanation for bridge vids field > > src/node/NetworkEdit.js | 72 +++++++++++++++++++++++++++++++++++++++++ > src/node/NetworkView.js | 5 +++ > 2 files changed, 77 insertions(+) > > manager: Aaron Lauterer (2): > fix #3893: api: network: add bridge_vids parameter > fix #3893: ui: network: enable bridge_vids field > > PVE/API2/Network.pm | 23 ++++++++++++++++++++++- > www/manager6/node/Config.js | 1 + > 2 files changed, 23 insertions(+), 1 deletion(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel