From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 076141FF398 for <inbox@lore.proxmox.com>; Mon, 13 May 2024 13:15:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5E98B13F22; Mon, 13 May 2024 13:15:14 +0200 (CEST) Message-ID: <a4314890-b59d-41fc-982e-74e72b6be96d@proxmox.com> Date: Mon, 13 May 2024 13:15:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Christoph Heiss <c.heiss@proxmox.com> References: <20240513094936.412650-1-c.heiss@proxmox.com> From: Aaron Lauterer <a.lauterer@proxmox.com> In-Reply-To: <20240513094936.412650-1-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer v2 0/4] assistant: clean up glob patterns & regexes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> did some tests on my local machine with the `device-info` and `device-match` subcommands to list and match against identifiers of disks and my NIC. Thanks for taking the time to improve this code. consider this series: Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com> Tested-By: Aaron Lauterer <a.lauterer@proxmox.com> On 2024-05-13 11:49, Christoph Heiss wrote: > The proxmox-auto-install-assistant uses > - glob patterns for disk matching, which can be pre-compiled for > efficiency > - regexes for udev property matching, which can be simplified by some > simple prefix matching & splitting on = > > The latter also significantly reduces binary size due to the removing > the regex dependency, for details see patch #4. > > Overall no functional changes in this series. > > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063802.html > > Changes v1 -> v2: > * rebased on latest master > > Christoph Heiss (4): > tree-wide: run rustfmt, fix clippy warnings > assistant: drop unused `log` dependency > assistant: pre-compile ignored block device patterns > assistant: avoid regex for simple prefix matching > > proxmox-auto-install-assistant/Cargo.toml | 2 - > proxmox-auto-install-assistant/src/main.rs | 75 ++++++++----------- > proxmox-auto-installer/tests/parse-answer.rs | 14 ++-- > .../src/fetch_plugins/partition.rs | 10 +-- > 4 files changed, 45 insertions(+), 56 deletions(-) > > -- > 2.44.0 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel