From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1561392D86 for ; Wed, 15 Feb 2023 10:05:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E704A1A5D8 for ; Wed, 15 Feb 2023 10:05:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 15 Feb 2023 10:05:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 211BF47176 for ; Wed, 15 Feb 2023 10:05:10 +0100 (CET) Message-ID: Date: Wed, 15 Feb 2023 10:05:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 To: Thomas Lamprecht , Proxmox VE development discussion References: <20230213102452.43253-1-l.nunner@proxmox.com> <47190234-9400-4060-0a92-d774eda7c436@proxmox.com> Content-Language: en-US From: Leo Nunner In-Reply-To: <47190234-9400-4060-0a92-d774eda7c436@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.35 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] feature #3937: config: store user in meta property X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2023 09:05:41 -0000 On 2023-02-14 10:41, Thomas Lamprecht wrote: > On 13/02/2023 11:24, Leo Nunner wrote: >> Adds a field to the "meta" config property which stores the user who >> created the VM. > Should also get this finally added to CTs, I know it's a bit unfair to > add the burden to this patch series, but otherwise we might never add > it.. > >> Signed-off-by: Leo Nunner >> --- >> PVE/QemuServer.pm | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm >> index a0e16dc..28ed8e7 100644 >> --- a/PVE/QemuServer.pm >> +++ b/PVE/QemuServer.pm >> @@ -281,6 +281,11 @@ my $meta_info_fmt = { >> pattern => '\d+(\.\d+)+', >> optional => 1, >> }, >> + 'user' => { > It adds a bit of property length, but it might be good to follow the other > properties and use a bit more self-explanatory 'creation-user' here? Good idea, I'll change it accordingly. > I mean, I don't hope that we add to much properties here, but in retrospect > the property name "meta" might have been a bit to general, something like > "creation-env" could have been a better choice - but as said, I still > hope that we don't add to much there anyway. > > otoh, maybe this is even "to much" for such a thing, a dedicated audit log > might be better in general? (I got that with some rough planning on our > internal wiki) FWIW, I actually started working on the CT implementation already (after Fiona pointed out that the report was requesting it for both VMs and CTs). I read through the ideas for the auditing framework and it does seem like it would be a much better fit there - but then again, the property might make accountability a bit easier, since instead of filtering logs (which could probably be quite some time in the past) one just needs to read the meta property in the config file… Maybe both would be good?