From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E48CF6D90F for ; Tue, 17 Aug 2021 17:32:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D1BD323883 for ; Tue, 17 Aug 2021 17:32:13 +0200 (CEST) Received: from mail.herold.me (mail.herold.me [90.187.0.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7DB4723872 for ; Tue, 17 Aug 2021 17:32:09 +0200 (CEST) X-Virus-Scanned: Yes DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=herold.me; s=mail; t=1629214320; bh=bFIsMt/gOq5651GdQu96Nj8k2reRC80pH74c4T6tbOI=; h=Subject:To:Cc:References:From:In-Reply-To; b=mnRgpJjWzc6OvtEYqBZ8R8V70EznthKcKClbGGbF8SSXj/ebHU+reGYNlsoKbpjpn ix0eCcQgAV/ot2uzROzf0drqf01at7V2FEvZ1E56Ks/WZkIwJRrvgV0IAcdvyeZgpH CzLvWjD3DhL/sKn2M/zaNzzBZ9ludCXV83zZ9T/I= To: Wolfgang Bumiller Cc: pve-devel@lists.proxmox.com References: <20210812181642.1818-1-proxmox8914@herold.me> <20210817132148.b5zjoct22ccm4ste@olga.proxmox.com> From: Constantin Herold Message-ID: Date: Tue, 17 Aug 2021 17:32:00 +0200 Mime-Version: 1.0 In-Reply-To: <20210817132148.b5zjoct22ccm4ste@olga.proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.750 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain KAM_INFOUSMEBIZ 0.75 Prevalent use of .info|.us|.me|.me.uk|.biz|xyz|id|rocks|life domains in spam/malware SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [memory.pm, herold.me] Subject: Re: [pve-devel] [PATCH qemu-server] fix #3581: pass size via argument for memory-backend-ram qmp call X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Aug 2021 15:32:43 -0000 Sure no problem. In that case the patch will probably break memory hotplug for any VM's tagged to Qemu <=4.2 Since VM's by default are tagged to >= 5.x that shouldn't be a issue though. Am 17.08.2021 um 15:21 schrieb Wolfgang Bumiller: > Hi, > > On Thu, Aug 12, 2021 at 08:16:42PM +0200, Constantin Herold wrote: >> Signed-off-by: Constantin Herold >> --- >> PVE/QemuServer/Memory.pm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm >> index f3e15f1..e34727f 100644 >> --- a/PVE/QemuServer/Memory.pm >> +++ b/PVE/QemuServer/Memory.pm >> @@ -155,7 +155,7 @@ sub qemu_memory_hotplug { >> eval { hugepages_update_locked($code); }; >> >> } else { >> - eval { mon_cmd($vmid, "object-add", 'qom-type' => "memory-backend-ram", id => "mem-$name", props => { size => int($dimm_size*1024*1024) } ) }; >> + eval { mon_cmd($vmid, "object-add", 'qom-type' => "memory-backend-ram", id => "mem-$name", size => int($dimm_size*1024*1024) ) }; > Looks fine. > > There's another `object-add` command a few lines higher up which also > still uses `props` and needs to be changed in the same way. > > Care to include it in a v2? > It would also be nice to include the cause in the commit message, > something like: > > `props` was deprecated with qemu 5.0 and removed in qemu 6.0. > The commands are now generally flattened. >