From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D8F99F5E5 for ; Fri, 29 Sep 2023 13:57:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 995C91FF5B for ; Fri, 29 Sep 2023 13:57:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 29 Sep 2023 13:57:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6F25748E50; Fri, 29 Sep 2023 13:57:33 +0200 (CEST) Message-ID: Date: Fri, 29 Sep 2023 13:57:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: Proxmox VE development discussion , Alexandre Derumier References: <20230929082859.147270-1-aderumier@odiso.com> From: Fiona Ebner In-Reply-To: <20230929082859.147270-1-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.656 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.473 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 0/2] migration: fix sporadic nbd-server-stop timeout X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2023 11:57:35 -0000 Am 29.09.23 um 10:28 schrieb Alexandre Derumier: > I'm not sure, maybe it's related to writeback, because it never happend with a fresh started vm, but vms running since some time can trigger this. > (I'm not sure, maybe nbd need to flush pending datas in cache ?) > It does drain the export's BlockBackend, i.e. wait for all pending IO before detaching/closing the export. But we did cancel the mirror job, which should actually wait for any in-flight IO already, so it's a bit surprising. Maybe there's some cache interaction happening at an inconvenient time, no idea ¯\_(ツ)_/¯ The other thing it does is closing the connection to the client, so there is at least that IO interaction and a higher timeout makes sense. > > Alexandre Derumier (2): > nbd_stop: increase timeout to 25s > migration: add missing eval on nbdstop with tunnel v2. > Patches look good to me, so consider them Reviewed-by: Fiona Ebner but they are missing your Signed-off-by trailer. Can you please add that?