From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7C0AA617B0 for ; Wed, 9 Feb 2022 18:36:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 67968563A for ; Wed, 9 Feb 2022 18:35:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E414A562C for ; Wed, 9 Feb 2022 18:35:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B615246D9E for ; Wed, 9 Feb 2022 18:35:34 +0100 (CET) Message-ID: Date: Wed, 9 Feb 2022 18:35:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20220127105601.2741602-1-d.csapak@proxmox.com> <20220127105601.2741602-7-d.csapak@proxmox.com> Cc: Wolfgang Bumiller From: Thomas Lamprecht In-Reply-To: <20220127105601.2741602-7-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH common 1/1] PBSClient: add option for extra parameter to file_restore_list X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Feb 2022 17:36:05 -0000 On 27.01.22 11:55, Dominik Csapak wrote: > we will need some extra parameters here, and instead of hardcoding them, > have the option to set a list of arbitrary parameters > > Signed-off-by: Dominik Csapak > --- > src/PVE/PBSClient.pm | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm > index 21dc363..dfb9f27 100644 > --- a/src/PVE/PBSClient.pm > +++ b/src/PVE/PBSClient.pm > @@ -342,11 +342,15 @@ sub status { > }; > > sub file_restore_list { > - my ($self, $snapshot, $filepath, $base64) = @_; > + my ($self, $snapshot, $filepath, $base64, $extraParams) = @_; > + > + my $params = [ $snapshot, $filepath, "--base64", $base64 ? 1 : 0 ]; > + push @$params, @$extraParams; > + > return run_client_cmd( > $self, > "list", > - [ $snapshot, $filepath, "--base64", $base64 ? 1 : 0 ], > + $params, > 0, > "proxmox-file-restore", > ); CC'ing Wolfgang, as IIRC he does not like passing "take anything" variables especially in such dynamic languages like perl. FWICT we only call file_restore_list once, and you set the options fixed there now, so why not just avoid the new method param and pass it directly fixed here?