From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 52EEC1FF137 for ; Tue, 17 Feb 2026 07:39:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 35EA01DC34; Tue, 17 Feb 2026 07:39:54 +0100 (CET) Message-ID: Date: Tue, 17 Feb 2026 07:39:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC proxmox 00/22] New crate for firewall api types To: Hannes Laimer , pve-devel@lists.proxmox.com References: <20260216104401.3959270-1-dietmar@proxmox.com> Content-Language: en-US From: Dietmar Maurer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771310382805 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.338 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GXWSDL354MJNY6A7Z5H4PYMKAJGSGZWN X-Message-ID-Hash: GXWSDL354MJNY6A7Z5H4PYMKAJGSGZWN X-MailFrom: dietmar@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > I was wondering if we actually need/want a separate crate. This > could be part of `pve-api-types`, alongside the verifiers we'd also have > something like `external types` that the generator can use if specified > for specific endpoints. The rational here would be, that for endpoint > where we want more than just verifiers we could define the types > directly. This would also make it somewhat straightforward to introduce > concrete typing in other, unrelated, places where that would make sense. > > On the other hand, for re-usability without the general pve stuff having > a crate might be handy. If you start implementing the firewall in Rust, you probably won't want to import all types from pve-api-types — that's unnecessary... - Dietmar