From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1355F1FF13F for ; Thu, 26 Mar 2026 10:54:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E7BF9AD27; Thu, 26 Mar 2026 10:54:42 +0100 (CET) Message-ID: Date: Thu, 26 Mar 2026 10:53:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner Subject: Re: [PATCH pve-manager 2/8] ui: CPUModelSelector: Fix dirty state on default To: Arthur Bied-Charreton , pve-devel@lists.proxmox.com References: <20260312084021.124465-1-a.bied-charreton@proxmox.com> <20260312084021.124465-3-a.bied-charreton@proxmox.com> Content-Language: en-US In-Reply-To: <20260312084021.124465-3-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774518798161 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QZ454PQD4N5NCQ37JDVFY5YFIIQVJUU5 X-Message-ID-Hash: QZ454PQD4N5NCQ37JDVFY5YFIIQVJUU5 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 12.03.26 um 9:40 AM schrieb Arthur Bied-Charreton: > 'originalValue' is set to null in case it's the default, but getValue > returns an empty string. This means that when editing a VM's CPU config > when the model is 'default', the form would always be marked dirty. > > Original patch: > https://lore.proxmox.com/pve-devel/20211028114150.3245864-7-s.reiter@proxmox.com/ > I wonder if this is (still) needed? If I remove the getValue() function, and instead add the following in www/manager6/form/CPUModelSelector.js setValue: function (value) { let me = this; me.callParent([value]); console.log('val: ' + value + ' dirty: ' + me.isDirty()); }, for debugging, it doesn't seem to be dirty when the default is set. > Originally-by: Stefan Reiter > Signed-off-by: Arthur Bied-Charreton > --- > www/manager6/form/CPUModelSelector.js | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/form/CPUModelSelector.js b/www/manager6/form/CPUModelSelector.js > index 2ebd08eb..737b6ff4 100644 > --- a/www/manager6/form/CPUModelSelector.js > +++ b/www/manager6/form/CPUModelSelector.js > @@ -39,7 +39,11 @@ Ext.define('PVE.form.CPUModelSelector', { > ], > width: 360, > }, > - > + getValue: function () { > + let me = this; > + let val = me.callParent(); > + return val === '' ? null : val; > + }, > store: { > autoLoad: true, > model: 'PVE.data.CPUModel',