From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BE14A606AF for ; Wed, 2 Dec 2020 15:00:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BC08C1C7D1 for ; Wed, 2 Dec 2020 15:00:04 +0100 (CET) Received: from jack.fr.eu.org (equ57-h01-128-78-42-217.dsl.sta.abo.bbox.fr [128.78.42.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3CA901C7C4 for ; Wed, 2 Dec 2020 15:00:04 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by jack.fr.eu.org (Postfix) with ESMTP id 0BE59106123B for ; Wed, 2 Dec 2020 14:50:53 +0100 (CET) Received: from jack.fr.eu.org ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QyZe9seKBsM9 for ; Wed, 2 Dec 2020 14:50:52 +0100 (CET) Received-SPF: softfail (jack.fr.eu.org: Sender is not authorized by default to use 'px@jack.fr.eu.org' in 'mfrom' identity, however domain is not currently prepared for false failures (mechanism '~all' matched)) receiver=jack.fr.eu.org; identity=mailfrom; envelope-from="px@jack.fr.eu.org"; helo="[192.168.1.50]"; client-ip=192.168.1.50 Received: from [192.168.1.50] (unknown [192.168.1.50]) by jack.fr.eu.org (Postfix) with ESMTPSA id C7DB21076F14 for ; Wed, 2 Dec 2020 14:50:51 +0100 (CET) To: pve-devel@lists.proxmox.com From: px@jack.fr.eu.org Message-ID: Date: Wed, 2 Dec 2020 14:50:51 +0100 User-Agent: Debian/9.0 Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment PDS_RDNS_DYNAMIC_FP 0.001 RDNS_DYNAMIC with FP steps RDNS_DYNAMIC 0.363 Delivered to internal network by host with dynamic-looking rDNS SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] ovf duplicate AddressOnParent X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2020 14:00:04 -0000 Hello, We are moving VMs from vmware to proxmox The process follows: - export the VM using ovftool - import using qm importovf We are facing an issue on multi-disk VM: all the disks are attached as scsi0 (which fails, and abort the process) From /usr/share/perl5/PVE/CLI/qm.pm, that value came from PVE::QemuServer::OVF::parse_ovf And from /usr/share/perl5/PVE/QemuServer/OVF.pm, that value came from rasd:AddressOnParent, from the OVF file And indeed, in the OVF file: 0 Hard disk 1 ovf:/disk/vmdisk1 11 5 17 0 Hard disk 2 ovf:/disk/vmdisk2 12 4 17 -> both disk has the same AddressOnParent, 0, because they do not share the same Parent (respectively 5 and 4) Parents are, according to the OVF's spec, "The InstanceID of the parent controller" So now, what should we do ? I wonder if we could simply increment that number for each disk found, in the loop: first disk gets scsi0, second gets scsi1 etc Thanks