From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7A6CD98296 for ; Sat, 22 Apr 2023 09:04:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5647721C57 for ; Sat, 22 Apr 2023 09:03:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 22 Apr 2023 09:03:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 59F2941E83; Sat, 22 Apr 2023 09:03:30 +0200 (CEST) Message-ID: Date: Sat, 22 Apr 2023 09:03:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: Proxmox VE development discussion , Alexandre Derumier References: <20230420213711.687478-1-aderumier@odiso.com> <20230420213711.687478-3-aderumier@odiso.com> From: Thomas Lamprecht In-Reply-To: <20230420213711.687478-3-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH ifupdown2 2/2] patch: add vlan interface ifdown/ifup when changes on reload, like for vxlan X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Apr 2023 07:04:01 -0000 On 20/04/2023 23:37, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > ...-down-up-vxlan-interfaces-when-ifreload_down.patch | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/debian/patches/pve/0005-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch b/debian/patches/pve/0005-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch > index c9964af..63494c9 100644 > --- a/debian/patches/pve/0005-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch > +++ b/debian/patches/pve/0005-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch > @@ -1,13 +1,16 @@ > From 2c38d0a157c8946f35a7da1c7c05484d33e6986f Mon Sep 17 00:00:00 2001 > From: Alexandre Derumier > Date: Wed, 5 Jun 2019 14:47:05 +0200 > -Subject: [PATCH 6/7] ifreload: down/up vxlan interfaces when > +Subject: [PATCH 6/7] ifreload: down/up vxlan && vlan interfaces when > ifreload_down_changed=0 > > almost all attributes of vxlan interfaces can't be updated > -in current kernel (<= 5.2). (including vxlan-id) > +(including vxlan-id). > > -so when ifreload_down_changed=0, ifreload can't update vxlan. > +Same for vlan interfaces (vlan-protocol, vlan-id) > + > +so when ifreload_down_changed=0, ifreload can't update vxlan or vlan > + attributes. > > fix: https://github.com/CumulusNetworks/ifupdown2/issues/50 > Signed-off-by: Alexandre Derumier > @@ -25,7 +28,7 @@ index b4e1864..9313573 100644 > ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind))) > ifacedownlist.append(newifaceobjlist[objidx].name) > - if not down_changed: > -+ if not down_changed and ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind) != 'vxlan': > ++ if not down_changed and ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind) != 'vxlan' and ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind) != 'vlan': style nit: could be slightly nicer if we pull out the link_kind into an intermediate variable, i.e., something like: link_kind = ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind) if not down_changed and link_kind != 'vxlan' and link_kind != 'vlan': > continue > if len(newifaceobjlist) != len(lastifaceobjlist): > ifacedownlist.append(ifname)