From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D407E1FF16B for ; Fri, 7 Nov 2025 10:11:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 24AD5C3A8; Fri, 7 Nov 2025 10:12:27 +0100 (CET) Message-ID: Date: Fri, 7 Nov 2025 10:12:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Daniel Kral References: <20251031122834.62482-1-f.ebner@proxmox.com> <20251031122834.62482-5-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762506723529 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 4/7] cpu config: introduce vendor-agnostic 'nested-virt' CPU flag X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 06.11.25 um 6:00 PM schrieb Daniel Kral: > On Fri Oct 31, 2025 at 1:27 PM CET, Fiona Ebner wrote: >> @@ -578,8 +588,34 @@ sub print_cpu_device { >> sub resolve_cpu_flags { >> my $flags = {}; >> >> + my $nested_flag; >> + my $nested_flag_resolved; >> + my $resolve_nested_flag = sub { >> + if (!$nested_flag_resolved) { >> + my $host_cpu_flags = PVE::ProcFSTools::read_cpuinfo()->{flags}; >> + if ($host_cpu_flags =~ m/\s(svm|vmx)\s/) { >> + $nested_flag = $1; >> + } else { >> + log_warn("ignoring 'nested-virt' CPU flag - unable to resolve from host CPU flags"); >> + } >> + $nested_flag_resolved = 1; >> + } >> + return $nested_flag; >> + }; >> + >> for my $hash (@_) { > > nit: maybe now's a good time to give @_ a name with the $nested_flag bit > in between? But I can see the naming collision with $flags.. That's a good point, perlcritic also has a warning about this: "Always unpack @_ first" Will fix in v2. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel