From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 3F84A1FF0C1 for ; Wed, 26 Aug 2026 14:16:14 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9D9FF21401; Wed, 26 Aug 2026 14:16:13 +0200 (CEST) Message-ID: Date: Wed, 26 Aug 2026 14:16:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH manager/network v2 0/2] sdn: add guest/nic selectors to IPAM create window To: pve-devel@lists.proxmox.com References: <20260826111322.1111478-1-h.laimer@proxmox.com> From: Hannes Laimer Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787746561028 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.961 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YSAJZIP5GBZBAZA4EDQ25L3CMFDBS4KC X-Message-ID-Hash: YSAJZIP5GBZBAZA4EDQ25L3CMFDBS4KC X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-08-26 13:43, Gabriel Goller wrote: > Small nit: the submitValue property doesn't need to be in the cBind, we could > just always set it to true. > we could, but on update the mac only gets submitted because its part of `extraRequestParams` in DhcpTree, so forcing this to true would technically also change the update behavior.. result should be the same though > LGTM though. thanks for taking a look! > > Tested-by: Gabriel Goller > Reviewed-by: Gabriel Goller