From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 01C9F8DC0C for ; Wed, 9 Nov 2022 15:51:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D46F31DE73 for ; Wed, 9 Nov 2022 15:51:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 9 Nov 2022 15:51:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5B5E740B5D for ; Wed, 9 Nov 2022 15:51:12 +0100 (CET) Message-ID: Date: Wed, 9 Nov 2022 15:51:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Matthias Heiserer References: <20221109115828.137770-1-m.heiserer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221109115828.137770-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series: [PATCH docs 00/10] docs (mostly) spelling update X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2022 14:51:14 -0000 Am 09/11/2022 um 12:58 schrieb Matthias Heiserer: > These are mostly about the first chapters, I'll try to look through the later ones aswell. > Many small patches, feel free to squash them, but I figured it's easier that way when the inevitable > discussions about proper spelling arise :) > > > Matthias Heiserer (10): > consistently use 'web interface' (two words) > remove misplaced comma > consistently capitalize Ceph > add note that secure boot needs to be disabled for host installation > UPDATE IMAGE IN DOCSgit diff pve-installation.adocgit diff > pve-installation.adoc! Installation options were moved into advanced > folder, update docs to reflect that. > add missing comma in if sentences > rephrase when root password is set to make it clear that when logging > it, it is already set > add missing letter > it's -> its because it isn't 'it is' > update link to debian handbook. current one is 404 > > certificate-management.adoc | 2 +- > hyper-converged-infrastructure.adoc | 6 +++--- > pve-installation.adoc | 18 +++++++++--------- > pve-storage-pbs.adoc | 2 +- > pve-storage-rbd.adoc | 4 ++-- > pveceph.adoc | 6 +++--- > sysadmin.adoc | 4 ++-- > 7 files changed, 21 insertions(+), 21 deletions(-) > applied series, thanks! Note that I squashed two patches and reworded a few commit messages slightly. Most of how you separated the series was pretty good (e.g., some tree wide change for consistent Ceph spelling makes sense in one patch) but I think in general you might want to have simple, obvious typo fixes (i.e., no big rewordings) from the same chapter squashed into a single patch and prefix the commit subject with the chapter/topic (like "installation:" or "ceph:") but at least squashing is really quickly done from my side (and always simpler than splitting up again), so I didn't mind about how you did the separation, just noting that I don't expected/want every single specific typo in its own patch.