From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1ED231FF163 for ; Thu, 5 Dec 2024 13:43:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E2CB19F4A; Thu, 5 Dec 2024 13:43:33 +0100 (CET) Message-ID: Date: Thu, 5 Dec 2024 13:42:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Gabriel Goller , pve-devel@lists.proxmox.com References: <20241205102348.216706-1-g.goller@proxmox.com> <20241205102348.216706-2-g.goller@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: <20241205102348.216706-2-g.goller@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs] Subject: Re: [pve-devel] [PATCH v2] log: add perlmod logger X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 2024-12-05 11:23, Gabriel Goller wrote: > Add special logger for perlmod. This one will print everything to > stderr (which will end up in the tasklog) and the errors to journald. > > Reported-by: Maximiliano Sandoval > Reported-by: Lukas Wagner > Signed-off-by: Gabriel Goller > --- > > v2: > - nothing changed > > proxmox-log/src/lib.rs | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/proxmox-log/src/lib.rs b/proxmox-log/src/lib.rs > index 8c74e42b618d..5713c094e981 100644 > --- a/proxmox-log/src/lib.rs > +++ b/proxmox-log/src/lib.rs > @@ -191,3 +191,38 @@ pub fn init_cli_logger( > LogTracer::init_with_filter(log_level.as_log())?; > Ok(()) > } > + > +/// Initialize logger for perlmod > +/// > +/// This logger will log everything to stderr (which will land in the tasklog) > +/// and the errors to syslog as well. > +pub fn init_perlmod_logger( > + env_var_name: &str, > + default_log_level: LevelFilter, > +) -> Result<(), anyhow::Error> { > + let mut log_level = default_log_level; > + if let Ok(v) = env::var(env_var_name) { > + match v.parse::() { > + Ok(l) => { > + log_level = l; > + } > + Err(e) => { > + eprintln!("env variable {env_var_name} found, but parsing failed: {e:?}"); > + } > + } > + } > + > + let registry = tracing_subscriber::registry() > + .with( > + tracing_journald::layer().ok() > + .with_filter(filter_fn(|metadata| { > + *metadata.level() == Level::ERROR > + })) > + .with_filter(log_level), > + ) > + .with(plain_stderr_layer().with_filter(log_level)); > + > + tracing::subscriber::set_global_default(registry)?; > + LogTracer::init_with_filter(log_level.as_log())?; > + Ok(()) > +} Minor nit: repo in the subject prefix is missing, also the order of patches should probably reversed. Seems to work fine, now messages logged by proxmox-notify while being in task context show up in the task logs again. Only downside to this approach is that we now also log to stderr in regular daemon (non-task) context? I don't think this is an issue tho? Small (visual) improvement would be to log the severity as well, similar to the rest of the task logs. E.g. INFO: notified via ... ERROR: could not notify via ... At the moment the prefix is not there, which is inconsistent to the other messages in the task log. Consider this: Tested-by: Lukas Wagner -- - Lukas _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel