From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AC7067E3F1 for ; Wed, 10 Nov 2021 13:42:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9BD6E1BE0F for ; Wed, 10 Nov 2021 13:42:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BF0541BE04 for ; Wed, 10 Nov 2021 13:42:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8F727439B3 for ; Wed, 10 Nov 2021 13:42:27 +0100 (CET) To: pve-devel@lists.proxmox.com, =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20211105130359.40803-1-f.gruenbichler@proxmox.com> From: Fabian Ebner Message-ID: Date: Wed, 10 Nov 2021 13:42:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211105130359.40803-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.678 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH-series qemu-server++ 0/22] remote migration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 12:42:58 -0000 Mostly just nits and suggestions from my side, but there are a handful of (easily-fixed) issues too. For the patches for access-control, common, http-server (although I don't feel qualified there) and patches for qemu-server where I didn't reply: Reviewed-by: Fabian Ebner Am 05.11.21 um 14:03 schrieb Fabian Grünbichler: > this series adds remote migration for VMs. there's still some of > TODOs/FIXMEs/stuff that requires discussion left, but this should > hopefully be possible to apply with minor modifications and lots of > future extensions. > > both live and offline migration including NBD and storage-migrated disks > should work. > > besides lots of rebases, implemented todos and fixed issues the main > difference to the previous RFC is that we no longer define remote > entries in a config file, but just expect the caller/client to give us > all the required information to connect to the remote cluster. > > overview over affected repos and changes, see individual patches for > more details. > > proxmox: > > some compatible changes to make websocket code usable for client-side > connections, required by proxmox-websocket-tunnel > > proxmox-websocket-tunnel: > > new tunnel helper tool for forwarding commands and data over websocket > connections, required by qemu-server on source side > > pve-access-control: > > new ticket type, required by qemu-server on target side > > pve-common: > > bridgepair format akin to storage pair, pve-bridge-id option, required > by qemu-server > remote format for specifying a remote endpoint (including API token, > fingerprint, ..) > > pve-guest-common: > > handle remote migration (no SSH) in AbstractMigrate, > required by qemu-server > > pve-storage: > > extend 'pvesm import' to allow import from UNIX socket, required on > target node by qemu-server > > qemu-server: > > some refactoring, new mtunnel endpoints, new remote_migration endpoints > TODO: handle pending changes and snapshots > TODO: proper CLI for remote migration > potential TODO: precond endpoint? > > pve-http-server: > > fix for handling unflushed proxy streams > > as usual, some of the patches are best viewed with '-w', especially in > qemu-server.. > > required dependencies are noted, qemu-server also requires a build-dep > on patched pve-common since the required options/formats would be > missing otherwise.. > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >