From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6DEDC717D2 for ; Thu, 9 Sep 2021 14:26:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 624139D4B for ; Thu, 9 Sep 2021 14:26:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 86DD89D40 for ; Thu, 9 Sep 2021 14:26:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 58989421EF; Thu, 9 Sep 2021 14:26:18 +0200 (CEST) To: Fabian Ebner , pve-devel@lists.proxmox.com, aderumier@odiso.com References: <20210906131542.178844-1-l.stechauner@proxmox.com> <20210906131542.178844-2-l.stechauner@proxmox.com> <31f9f8d5-e356-65aa-9a9c-301c4d1f68c6@proxmox.com> From: Lorenz Stechauner Message-ID: Date: Thu, 9 Sep 2021 14:26:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 1.399 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.922 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage 1/1] fix #3580: plugins: make preallocation mode selectable for qcow2 and raw images X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 12:26:19 -0000 On 09.09.21 14:04, Fabian Ebner wrote: > Am 09.09.21 um 13:11 schrieb Lorenz Stechauner: >> >> On 09.09.21 12:25, Fabian Ebner wrote: >>> Am 08.09.21 um 10:11 schrieb alexandre derumier: >>>> Hi, >>>> it can be done too with ceph rbd with "rbd create ... >>>> –thick-provision" >>>> >>> >>> Hi, >>> there also is the 'sparse' storage config option (currently only >>> used for ZFS plugins). If there is only thick or thin, re-using that >>> one is probably nicer, because the newly proposed preallocation >>> option seems to be closely tied to qemu-img. >> >> Sounds like a good idea. I doubt, that anyone would use full >> prellocation anyway, so simply using 'sparse' for prealloc=off and >> default remains prealloc=metadata sounds good. >> > > I actually only meant re-using 'sparse' for the RBD use case. But yes, > it seems like re-using it for the qemu-img use case would be enough to > fix the bug too. It might be a bit confusing though, because when > sparse is not set, the images would still be mostly sparse (except for > metadata). makes sense, I got a bit confused by the rbd stuff. Then I won't update the patch to use 'sparse' :) > >>> >>>> Le lundi 06 septembre 2021 à 15:15 +0200, Lorenz Stechauner a écrit : >>>>> the plugins for file based storages >>>>>   * BTRFS >>>>>   * CIFS >>>>>   * Dir >>>>>   * Glusterfs >>>>>   * NFS >>>>> now allow the option 'preallocation'. >>>>> >>>>> 'preallocation' can have four values: >>>>>   * default >>>>>   * off >>>>>   * metadata >>>>>   * falloc >>>>>   * full >>>>> see man pages for `qemu-img` for what these mean exactly. [0] >>>>> >>>>> the defualt value was chosen to be >>>>>   * qcow2: metadata (as previously) >>>>>   * raw: off (I was unable to find any documentation on this, so >>>>>      could only test this and found, that 'off' was the most >>>>>      fitting.) >>>>> >>>>> when using 'metadata' as preallocation mode, for raw images 'off' >>>>> is used. >>>>> >>>>> [0] >>>>> https://qemu.readthedocs.io/en/latest/system/images.html#disk-image-file-formats >>>>> >>>>> >>>>> Signed-off-by: Lorenz Stechauner