From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9ABCB7CDB6 for ; Tue, 19 Jul 2022 13:54:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 986E3299E7 for ; Tue, 19 Jul 2022 13:54:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 19 Jul 2022 13:54:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7686840FA5 for ; Tue, 19 Jul 2022 13:54:52 +0200 (CEST) Date: Tue, 19 Jul 2022 13:54:50 +0200 From: Oguz Bektas To: Proxmox VE development discussion Message-ID: Mail-Followup-To: Oguz Bektas , Proxmox VE development discussion References: <20220719112456.298086-1-o.bektas@proxmox.com> <1658231483.00qrznxz22.astroid@nora.none> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1658231483.00qrznxz22.astroid@nora.none> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [base.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 11:54:53 -0000 On Tue, Jul 19, 2022 at 01:52:37PM +0200, Fabian Grünbichler wrote: > On July 19, 2022 1:24 pm, Oguz Bektas wrote: > > "both" option is deprecated, this gets rid of the warning in the journal > > > > Signed-off-by: Oguz Bektas > > some notion which templates you tested this with, when the deprecation > happened in systemd, whether we need a fallback to 'both' for older > versions, etc.pp. would be nice to have.. > > AFAICT the deprecation was in systemd v219, so should probably be okay > to switch unconditionally.. yes, all our current templates are using the newer systemd versions, so no need for a fallback IMO. i tested it with: * arch * fedora 35 and 36 * ubuntu 20 and 22 templates, it got rid of the warning in all of them. > > > --- > > src/PVE/LXC/Setup/Base.pm | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm > > index 8580bf0..cc12914 100644 > > --- a/src/PVE/LXC/Setup/Base.pm > > +++ b/src/PVE/LXC/Setup/Base.pm > > @@ -261,7 +261,7 @@ DATA > > my ($has_ipv4, $has_ipv6); > > > > # DHCP bitflags: > > - my @DHCPMODES = ('no', 'v4', 'v6', 'both'); > > + my @DHCPMODES = ('no', 'v4', 'v6', 'yes'); > > my ($NONE, $DHCP4, $DHCP6, $BOTH) = (0, 1, 2, 3); > > my $dhcp = $NONE; > > my $accept_ra = 'false'; > > -- > > 2.30.2 > > > > > > > > _______________________________________________ > > pve-devel mailing list > > pve-devel@lists.proxmox.com > > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > > > > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >