From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <o.bektas@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E138071BDF for <pve-devel@lists.proxmox.com>; Fri, 20 May 2022 10:04:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A3D691038D for <pve-devel@lists.proxmox.com>; Fri, 20 May 2022 10:03:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 32DA11036F for <pve-devel@lists.proxmox.com>; Fri, 20 May 2022 10:03:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 080D142F61 for <pve-devel@lists.proxmox.com>; Fri, 20 May 2022 10:03:58 +0200 (CEST) Date: Fri, 20 May 2022 10:03:56 +0200 From: Oguz Bektas <o.bektas@proxmox.com> To: Thomas Lamprecht <t.lamprecht@proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Message-ID: <YodLbHr7wpUu/f1E@gaia> Mail-Followup-To: Oguz Bektas <o.bektas@proxmox.com>, Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20220519084816.193338-1-o.bektas@proxmox.com> <c175eac4-b9c9-dbe9-2a93-bdb4d65ab903@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <c175eac4-b9c9-dbe9-2a93-bdb4d65ab903@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.498 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v5 manager] ui: vm network: allow to override MTU for virtio devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 20 May 2022 08:04:28 -0000 On Fri, May 20, 2022 at 09:41:10AM +0200, Thomas Lamprecht wrote: > On 19/05/2022 10:48, Oguz Bektas wrote: > > we already have the 'mtu' option in the API, so we can just expose > > that option inside the 'Advanced' menu for virtio network interfaces. > > > > Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com> > > Tested-By: Aaron Lauterer <a.lauterer@proxmox.com> > > Tested-By: Dylan Whyte <d.whyte@proxmox.com> > > aren't those from two version previous with some change in between, or > did they re-test / re-review this in private? > As IMO it's not really correct to let one believe that this exact version > was tested by two people. sorry for the confusion, the tags were leftover from the previous commits > > Functionality wise it looks Ok, a few final layout and code style nits > I'd still like to see inline. i've addressed the nits in the v6. though i don't think the > "Use the special value '1' to inherit the MTU from the underlying bridge" is the best, since the user won't see this message until they've selected '1' as a value. regardless, i've made the changes you asked for - oguz