From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 21F7E61C7A for ; Thu, 10 Feb 2022 15:08:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 189671DF73 for ; Thu, 10 Feb 2022 15:08:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id ED7F81DF67 for ; Thu, 10 Feb 2022 15:08:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C569646AB4 for ; Thu, 10 Feb 2022 15:08:32 +0100 (CET) Date: Thu, 10 Feb 2022 15:08:31 +0100 From: Oguz Bektas To: Aaron Lauterer Cc: Proxmox VE development discussion Message-ID: Mail-Followup-To: Oguz Bektas , Aaron Lauterer , Proxmox VE development discussion References: <20220210112836.616619-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.638 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 manager] ui: vm network: allow to override MTU for virtio devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2022 14:08:34 -0000 On Thu, Feb 10, 2022 at 02:53:19PM +0100, Aaron Lauterer wrote: > Looks good AFAICT and does what we want. > > We could improve it further by adding a small validator. Otherwise the user will only notice their error once they get the error msg from the API. > > A quick way that I came up with that could potentially be done better: > > diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js > index 1e34ad1c..2566d1a8 100644 > --- a/www/manager6/qemu/NetworkEdit.js > +++ b/www/manager6/qemu/NetworkEdit.js > @@ -184,6 +184,13 @@ Ext.define('PVE.qemu.NetworkInputPanel', { > bind: { > disabled: '{!isVirtio}', > }, > + validator: function(value) { > + if (value === "" || (value > 0 && value <= 65520)) { > + return true; > + } else { > + return gettext("must be between 0 and 65520"); > + } > + }, > allowBlank: true, > }, > ]; > > > Besides this last improvement: > > Reviewed-By: Aaron Lauterer > Tested-By: Aaron Lauterer > thanks for the test and review! instead of a validator function i guess we could just set minValue and maxValue as well? (since allowBlank is set to true) seemed to work fine in my short testing just now :) diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js index 1e34ad1c..a3fa5724 100644 --- a/www/manager6/qemu/NetworkEdit.js +++ b/www/manager6/qemu/NetworkEdit.js @@ -184,6 +184,8 @@ Ext.define('PVE.qemu.NetworkInputPanel', { bind: { disabled: '{!isVirtio}', }, + minValue: 1, + maxValue: 65520, allowBlank: true, }, ];