From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 675AF61A5E for ; Thu, 10 Feb 2022 11:10:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 544C41B108 for ; Thu, 10 Feb 2022 11:10:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C17401B0FE for ; Thu, 10 Feb 2022 11:10:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 876FB46D5B for ; Thu, 10 Feb 2022 11:10:07 +0100 (CET) Date: Thu, 10 Feb 2022 11:10:05 +0100 From: Oguz Bektas To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: Mail-Followup-To: Oguz Bektas , Thomas Lamprecht , Proxmox VE development discussion References: <20220207121825.722340-1-o.bektas@proxmox.com> <3d9039a7-02c7-27bd-588c-c7fe41001380@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d9039a7-02c7-27bd-588c-c7fe41001380@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.645 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH pve-manager] NetworkEdit: allow setting 'mtu' option for guest network devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2022 10:10:38 -0000 hi, thx for the review :) On Wed, Feb 09, 2022 at 07:03:34PM +0100, Thomas Lamprecht wrote: > commit subject should rather be > > "ui: vm network: allow to override mtu for virtio devices" okay > > On 07.02.22 13:18, Oguz Bektas wrote: > > we already have the 'mtu' option inside the API, so we can just expose > > that option inside the 'Advanced' menu for guest network interfaces. > > We have that property since commit 61a14cde8d568e552d3deaab2da76b479b8aca7b but > it's only effective for when the VirtIO driver is used. The ui should reflect > that as it may get really confusing for users with e1000(e) or other non-virtio > models. MTU changes are notoriously tricky as it needs to be right in the whole > network path, so the UX is IMO important for this ah that's true! i'll send in a v2 :)