From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <o.bektas@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id E334D82E96
 for <pve-devel@lists.proxmox.com>; Wed,  1 Dec 2021 16:11:26 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id C5DC4FBBB
 for <pve-devel@lists.proxmox.com>; Wed,  1 Dec 2021 16:11:26 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 1D0C7FBB0
 for <pve-devel@lists.proxmox.com>; Wed,  1 Dec 2021 16:11:26 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EAEFB45C52
 for <pve-devel@lists.proxmox.com>; Wed,  1 Dec 2021 16:11:25 +0100 (CET)
Date: Wed, 1 Dec 2021 16:11:23 +0100
From: Oguz Bektas <o.bektas@proxmox.com>
To: Dylan Whyte <d.whyte@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Message-ID: <YaeQm5u9bMuKXi1w@gaia>
Mail-Followup-To: Oguz Bektas <o.bektas@proxmox.com>,
 Dylan Whyte <d.whyte@proxmox.com>,
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20211129123858.1320223-1-o.bektas@proxmox.com>
 <c7296592-029b-3ec4-c482-aa26d1e5dacf@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c7296592-029b-3ec4-c482-aa26d1e5dacf@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.734 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [proxmox.com, config.pm]
Subject: Re: [pve-devel] [PATCH] config: allow 'lazytime' mount option for
 containers
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 01 Dec 2021 15:11:26 -0000

On Wed, Dec 01, 2021 at 03:54:12PM +0100, Dylan Whyte wrote:
> Hi,
> 
> I just tested/played with this a bit and couldn't find any issues within the
> container, with the option enabled.
> 
> However, you need to add a corresponding mount option in the GUI, as
> otherwise, the "Edit: Mount Point" window breaks due to it not recognizing
> the option, and no changes can be made as a result.

oops yeah, thanks for pointing out! will send a manager patch :)


> 
> Tested-by: Dylan Whyte <d.whyte@proxmox.com>
> 
> On 11/29/21 1:38 PM, Oguz Bektas wrote:
> > requested in community forum [0]
> > 
> > root@CT1022:/# mount | grep lazy
> > /var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on /     type ext4 (rw,relatime,lazytime)
> > /var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on /snap type ext4 (rw,relatime,lazytime)
> > 
> > [0]: https://forum.proxmox.com/threads/100454/
> > 
> > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> > ---
> >   src/PVE/LXC/Config.pm | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> > index 1e28a88..6c2acd6 100644
> > --- a/src/PVE/LXC/Config.pm
> > +++ b/src/PVE/LXC/Config.pm
> > @@ -281,7 +281,7 @@ sub __snapshot_rollback_get_unused {
> >   cfs_register_file('/lxc/', \&parse_pct_config, \&write_pct_config);
> > -my $valid_mount_option_re = qr/(noatime|nodev|nosuid|noexec)/;
> > +my $valid_mount_option_re = qr/(noatime|lazytime|nodev|nosuid|noexec)/;
> >   sub is_valid_mount_option {
> >       my ($option) = @_;