From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9010681B4C for ; Thu, 25 Nov 2021 15:12:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F3DEE49C for ; Thu, 25 Nov 2021 15:11:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9341EE490 for ; Thu, 25 Nov 2021 15:11:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0F74A46871 for ; Thu, 25 Nov 2021 15:11:51 +0100 (CET) Date: Thu, 25 Nov 2021 15:11:49 +0100 From: Oguz Bektas To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: Mail-Followup-To: Oguz Bektas , Thomas Lamprecht , Proxmox VE development discussion References: <20211125134803.2320788-1-o.bektas@proxmox.com> <82e0c5e9-d31d-1366-8dc1-6502e8ec6c67@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82e0c5e9-d31d-1366-8dc1-6502e8ec6c67@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.759 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nodes.pm] Subject: Re: [pve-devel] [PATCH v2 manager] set https_proxy to http_proxy for querying url metadata X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Nov 2021 14:12:22 -0000 On Thu, Nov 25, 2021 at 03:08:24PM +0100, Thomas Lamprecht wrote: > On 25.11.21 14:48, Oguz Bektas wrote: > > Reviewed-by: Dominik Csapak > > where is this tag coming from? Did not see it on the list, only the comment > that it wasn't working? yes its fixed now... he did review it, and its only a single line, so i thought i'll add it before it gets forgotten along the way ;) > > > Signed-off-by: Oguz Bektas > > --- > > v1->v2: > > * thanks dominik for catching my error! > > > > PVE/API2/Nodes.pm | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm > > index d57a1937..96479848 100644 > > --- a/PVE/API2/Nodes.pm > > +++ b/PVE/API2/Nodes.pm > > @@ -1554,7 +1554,7 @@ __PACKAGE__->register_method({ > > > > my $dccfg = PVE::Cluster::cfs_read_file('datacenter.cfg'); > > if ($dccfg->{http_proxy}) { > > - $ua->proxy('http', $dccfg->{http_proxy}); > > + $ua->proxy(['http', 'https'], $dccfg->{http_proxy}); > > } > > > > my $verify = $param->{'verify-certificates'} // 1; > > >