From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BEF4D770EA for ; Thu, 21 Oct 2021 11:53:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9EAF91C33D for ; Thu, 21 Oct 2021 11:53:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E18761C332 for ; Thu, 21 Oct 2021 11:53:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B76C3468BF for ; Thu, 21 Oct 2021 11:53:22 +0200 (CEST) Date: Thu, 21 Oct 2021 11:53:20 +0200 From: Oguz Bektas To: Proxmox VE development discussion Message-ID: Mail-Followup-To: Oguz Bektas , Proxmox VE development discussion References: <20211012112052.437232-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211012112052.437232-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.909 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] fix removing cpulimit on running vm X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2021 09:53:53 -0000 hi, works for cgroupv2 but with 'systemd.unified_cgroup_hierarchy=0' in cmdline it errors: ==== update VM 101: -delete cpulimit 400 Parameter verification failed. cpulimit: hotplug problem - closing file '/sys/fs/cgroup/cpu/qemu.slice/101.scope//cpu.cfs_period_us' failed - Invalid argument ==== On Tue, Oct 12, 2021 at 01:20:52PM +0200, Dominik Csapak wrote: > like in pve-container: > 04a62bd ("fix #3506: config: fix removing the cpulimit of a running CT") > > reported in the forums (no bug# yet): > https://forum.proxmox.com/threads/issue-with-removing-cpu-limit-from-running-vm.97799/ > > Signed-off-by: Dominik Csapak > --- > PVE/QemuServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index eb29fc2..1d31d02 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -4754,7 +4754,7 @@ sub vmconfig_hotplug_pending { > } elsif ($opt eq 'cpuunits') { > $cgroup->change_cpu_shares(undef, 1024); > } elsif ($opt eq 'cpulimit') { > - $cgroup->change_cpu_quota(-1, 100000); > + $cgroup->change_cpu_quota(undef, undef); # reset, cgroup module can better decide values > } else { > die "skip\n"; > } > -- > 2.30.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >